Skip to content

Conversation

@Jonas-Isr
Copy link
Member

@Jonas-Isr Jonas-Isr commented Jul 23, 2025

Context

This PR migrates the release process of Cloud SDK to the new maven central endpoint. It also makes the release process more consistent with the release process of AI SDK.

You can find the successful test runs in the forked repository:

Feature scope:

  • release process uses https://central.sonatype.com/api/v1/publisher/upload now
  • release and CI workflows are aligned more with AI SDK

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@Jonas-Isr Jonas-Isr added the please review Request to review a pull request label Jul 23, 2025
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked whether all plugin configurations are migrated correctly. It's a lot.

<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.6.0</version>
<configuration>
<skip>true</skip>
Copy link
Contributor

@newtork newtork Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question) Do you need to skip this plugin if it isn't really defined for the module?

</plugin>
<plugin>
<groupId>org.projectlombok</groupId>
<artifactId>lombok-maven-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question) Can we omit plugin declarations targetting source-code, when the BOM wouldn't have any?

Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wished the plugin properties diff was smaller.

@newtork newtork merged commit f4e4284 into SAP:main Jul 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please review Request to review a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants